Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make permissions input idempotent and add placeholder #46

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Make permissions input idempotent and add placeholder #46

merged 1 commit into from
Apr 5, 2023
+2 −1

Conversation

SorenHolstHansen
Copy link
Contributor

This fixes #45 by not automatically adding WHERE ${value}), and adding a placeholder

@macjuul macjuul self-assigned this Apr 5, 2023
@macjuul
Copy link
Contributor

macjuul commented Apr 5, 2023

Good catch! Small mistake on my end

Could you see if permissions within fields are working correctly as well? I don't have much time to test it myself right now, if so I'll get this merged as soon as possible

@SorenHolstHansen
Copy link
Contributor Author

Yes, they had the same issue, and is fixed with this PR

@macjuul macjuul merged commit be02d8d into surrealdb:main Apr 5, 2023
@macjuul
Copy link
Contributor

macjuul commented Apr 5, 2023

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@macjuul macjuul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permission inputs are not idempotent and they are unclear how to use
2 participants
@SorenHolstHansen @macjuul